Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

chore: remove deprecated fxLayoutWrap #521

Closed
wants to merge 1 commit into from

Conversation

CaerusKaru
Copy link
Member

No description provided.

@CaerusKaru CaerusKaru force-pushed the dep branch 2 times, most recently from 66d990d to 91db203 Compare December 14, 2017 00:24
@ThomasBurleson
Copy link
Contributor

@CaerusKaru - seems reasonable to remove verbose API when option is already provided in fxLayout.

@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.13 milestone Dec 14, 2017
@CaerusKaru CaerusKaru added the pr: lgtm This PR has been approved by the reviewer label Jan 4, 2018
@ThomasBurleson
Copy link
Contributor

@CaerusKaru - while I like this. Perhaps we should deprecate this feature current HEAD and the next release and then formally remove it in two releases ?

@ThomasBurleson ThomasBurleson modified the milestones: v2.0.0-beta.13, v5.0.0-rc.1 Jan 4, 2018
@CaerusKaru
Copy link
Member Author

From the comment in fxLayoutWrap, it looks like it's been deprecated at least since beta.10. But I think it could wait until we bump major to 5.0.0

@ThomasBurleson
Copy link
Contributor

ThomasBurleson commented Jan 4, 2018 via email

@CaerusKaru CaerusKaru added release: patch This PR is targeted for the next patch release and removed pr: on hold labels Jan 5, 2018
@CaerusKaru CaerusKaru modified the milestones: v5.0.0-rc.1, v2.0.0-beta.13 Jan 5, 2018
@CaerusKaru CaerusKaru closed this Jan 15, 2018
@CaerusKaru CaerusKaru deleted the dep branch January 15, 2018 09:16
@CaerusKaru CaerusKaru removed this from the v2.0.0-beta.13 milestone Jan 15, 2018
ThomasBurleson pushed a commit that referenced this pull request Jan 15, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes pr: lgtm This PR has been approved by the reviewer release: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants