-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(icon): add input for inline styling of icons #9984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+51
−3
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,10 @@ | |
} | ||
} | ||
|
||
.mat-tab-label.mat-tab-label.mat-tab-label { | ||
min-width: 0; | ||
} | ||
|
||
.demo-tab-group { | ||
flex-grow: 1; | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,7 @@ import { | |
ViewEncapsulation, | ||
} from '@angular/core'; | ||
import {CanColor, mixinColor} from '@angular/material/core'; | ||
import {coerceBooleanProperty} from '@angular/cdk/coercion'; | ||
import {MatIconRegistry} from './icon-registry'; | ||
|
||
|
||
|
@@ -67,12 +68,26 @@ export const _MatIconMixinBase = mixinColor(MatIconBase); | |
host: { | ||
'role': 'img', | ||
'class': 'mat-icon', | ||
'[class.mat-icon-inline]': 'inline', | ||
}, | ||
encapsulation: ViewEncapsulation.None, | ||
changeDetection: ChangeDetectionStrategy.OnPush, | ||
}) | ||
export class MatIcon extends _MatIconMixinBase implements OnChanges, OnInit, CanColor { | ||
|
||
/** | ||
* Whether the icon should be inlined, automatically sizing the icon to match the font size of | ||
* the element the icon is contained in. | ||
*/ | ||
@Input() | ||
get inline(): boolean { | ||
return this._inline; | ||
} | ||
set inline(inline: boolean) { | ||
this._inline = coerceBooleanProperty(inline); | ||
} | ||
private _inline: boolean = false; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would be good to have one unit test that uses this. |
||
|
||
/** Name of the icon in the SVG icon set. */ | ||
@Input() svgIcon: string; | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does IE11 support
inherit
? Any reason for not using1em
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI:
inherit
is supported since IE8.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I was thinking of
initial
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use
1em
instead ofinherit
if you would like, I don't have a super strong preference at this point.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inherit
should be fine, I mixed up the IE support in my head