fix(list-key-manager): infinite loop if all items are disabled #9981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently if the `ListKeyManager` is being used in wrap mode, and all items are disabled, pressing the down arrow key will cause the key manager to go into an infinite loop that searches for the next item. Related angular#9963
devversion
added
pr: needs review
target: patch
googlebot
added
the
cla: yes
crisbeto
approved these changes
Feb 16, 2018
| // If the test setup crashes or this test times out, this test can be considered as failed. | ||
| it('should not get into an infinite loop if all items are disabled', () => { | ||
| keyManager.withWrap(); | ||
| keyManager.setActiveItem(0); |
There was a problem hiding this comment.
You can chain the withWrap and setActiveItem.
There was a problem hiding this comment.
I tried to keep it consistent with the rest of the tests. All of those don't seem to chain either.
|
|
||
| if (!item.disabled) { | ||
| this.setActiveItem(index); | ||
| break; |
There was a problem hiding this comment.
Might be a good idea to return here instead so we don't put some extra logic below by accident.
There was a problem hiding this comment.
Yeah that works too. Changed it
crisbeto
added
pr: lgtm
action: merge
devversion
added a commit
to devversion/material2
that referenced
this pull request
Feb 17, 2018
* Currently if a list option is disabled through the `[disabled]` binding, the disabled option still has the `pointer` cursor. * No longer delegates the keydown event to the ListKeyManager when disabled. Right now there can be an exception because all items are disabled. See angular#9981. Fixes angular#9952.
jelbourn
approved these changes
Feb 17, 2018
| this.setActiveItem(this._activeItemIndex); | ||
| private _setActiveInWrapMode(delta: -1 | 1, items: T[]): void { | ||
| for (let i = 1; i <= items.length; i++) { | ||
| const index = (this._activeItemIndex + delta * i + items.length) % items.length; |
There was a problem hiding this comment.
Use parentheses around the multiplication to make the order of operations explicit
tinayuangao
pushed a commit
that referenced
this pull request
Feb 20, 2018
Currently if the `ListKeyManager` is being used in wrap mode, and all items are disabled, pressing the down arrow key will cause the key manager to go into an infinite loop that searches for the next item. Related #9963
andrewseguin
pushed a commit
that referenced
this pull request
Feb 20, 2018
Currently if the `ListKeyManager` is being used in wrap mode, and all items are disabled, pressing the down arrow key will cause the key manager to go into an infinite loop that searches for the next item. Related #9963
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListKeyManageris being used in wrap mode, and all items are disabled, pressing the down arrow key will cause the key manager to go into an infinite loop that searches for the next item.Related #9963