Skip to content

fix(badge): hard to see in high contrast mode #9973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2018
Merged

fix(badge): hard to see in high contrast mode #9973

merged 1 commit into from
Feb 18, 2018

Conversation

crisbeto
Copy link
Member

Fixes the badge directive being hard to see in high contrast mode due to its background blending in with the app background.

@crisbeto
fix(badge): hard to see in high contrast mode
63afb94 
Fixes the badge directive being hard to see in high contrast mode due to its background blending in with the app background.
@crisbeto crisbeto added pr: needs review Accessibility This issue is related to accessibility (a11y) labels Feb 15, 2018
@crisbeto crisbeto requested a review from amcdnl as a code owner February 15, 2018 21:41
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 15, 2018
jelbourn
jelbourn approved these changes Feb 15, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 15, 2018
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 17, 2018
amcdnl
amcdnl approved these changes Feb 17, 2018
View reviewed changes
Copy link
Contributor

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 1b2f90c into angular:master Feb 18, 2018
tinayuangao pushed a commit that referenced this pull request Feb 20, 2018
@crisbeto @tinayuangao
fix(badge): hard to see in high contrast mode (#9973)
7221c03 
Fixes the badge directive being hard to see in high contrast mode due to its background blending in with the app background.
@andrewseguin andrewseguin added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Feb 20, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amcdnl amcdnl amcdnl approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @amcdnl @jelbourn @googlebot @andrewseguin