refactor(overlay): avoid circular type references #9907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
I tried this out internally and I think it fixes one issue, but I still end up with another issue. I need to consult with Martin to interpret it. |
crisbeto
force-pushed
the
9491/overlay-circular-references
branch
from
aee51c9 to
41b77d7
Compare
|
@crisbeto could you rebase this one? I want to do another presubmit to remember what the problem was |
crisbeto
force-pushed
the
9491/overlay-circular-references
branch
from
41b77d7 to
99e8b2d
Compare
|
Done. It needed a bit more work to get it up-to-speed with master. |
jelbourn
approved these changes
Jun 5, 2018
Currently there is a circular type reference between `OverlayRef`, `PositionStrategy`/`ScrollStrategy` and `OverlayConfig` which can cause issues with some build tools. These changes introduce the `OverlayRefBase` type to avoid the circular reference. Fixes angular#9491.
crisbeto
force-pushed
the
9491/overlay-circular-references
branch
from
99e8b2d to
fc78a3d
Compare
|
Renamed to |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is a circular type reference between
OverlayRef,PositionStrategy/ScrollStrategyandOverlayConfigwhich can cause issues with some build tools. These changes introduce theOverlayRefBasetype to avoid the circular reference.Fixes #9491.