-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs: add types to public methods and getters/setters #9612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Passes internal presubmit, just needs rebase |
Done, @jelbourn. |
@rafaelss95 Looks like a lint error due to having an unescaped HTML tag in a JSDoc. |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Done, @josephperrott. I messed up while I was rebasing and @googlebot removed the |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Part of #9558.
This:
private-docs
as they can be caught by parent class after docs: show inherited properties #9299;ControlValueAccessor
methods API;Relates to #8832.
cc @jelbourn.
I'm open to rephrase the title of this PR, feel free to suggest.