Skip to content

chore: fix missing cdk table overview #9574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Fixes that the cdk-table overview file is not showing up in the docs.

Fixes #9554.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 24, 2018
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 24, 2018
@devversion
Copy link
Member Author

Related PR on the material.angular.io/ repository: angular/material.angular.io#375

'tooltip-delay': {
title: 'Tooltips with delay',
title: 'Tooltip with a show and hide delay',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto-generated. You need to update the @title in each example.

Copy link
Member Author

@devversion devversion Jan 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry (should have mentioned it in the PR description): those are the up-to-date descriptions from the actual @title comments. The titles recently got updated, but the example-module just didn't get updated.

devversion added a commit to devversion/material2 that referenced this pull request Jan 25, 2018
* No longer pushes the example-module.ts file to the GitHub repository. The file will be auto-generated once the `material-examples` build package is being built.

References angular#9574.
devversion added a commit to devversion/material2 that referenced this pull request Jan 25, 2018
* No longer pushes the example-module.ts file to the GitHub repository. The file will be auto-generated once the `material-examples` build package is being built.

References angular#9574.
jelbourn pushed a commit that referenced this pull request Jan 25, 2018
No longer pushes the example-module.ts file to the GitHub repository. The file will be auto-generated once the `material-examples` build package is being built.

References #9574.
@jelbourn
Copy link
Member

@devversion could you rebase?

Fixes that the cdk-table overview file is not showing up in the docs.

Fixes angular#9554.
@devversion devversion force-pushed the chore/fix-missing-cdk-table-overview branch from 18c321b to f214f83 Compare January 25, 2018 20:44
@devversion
Copy link
Member Author

@jelbourn Done.

@jelbourn jelbourn merged commit 7613f98 into angular:master Jan 25, 2018
@devversion devversion deleted the chore/fix-missing-cdk-table-overview branch January 25, 2018 21:01
@jelbourn jelbourn added target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels Jan 29, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDK Table Overview Documentation Not Showing
4 participants