Skip to content

chore: additional files for examples are missing #9548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

devversion
Copy link
Member

  • Due to recent changes to the example-data file, the ExampleData class accidentally no longer adds the additional files to the exampleFiles property. This means that those files aren't copied over to StackBlitz.
  • Cleans up the example data file.

Fixes #9541.

* Due to recent changes to the `example-data` file, the `ExampleData` class accidentally no longer adds the additional files to the `exampleFiles` property. This means that those files aren't copied over to StackBlitz.
* Cleans up the example data file.

Fixes angular#9541.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 23, 2018
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 23, 2018
@jelbourn jelbourn merged commit e5c8880 into angular:master Jan 23, 2018
@devversion devversion deleted the chore/additional-files-missing branch January 23, 2018 21:12
tinayuangao pushed a commit that referenced this pull request Jan 24, 2018
* Due to recent changes to the `example-data` file, the `ExampleData` class accidentally no longer adds the additional files to the `exampleFiles` property. This means that those files aren't copied over to StackBlitz.
* Cleans up the example data file.

Fixes #9541.
@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Jan 29, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 29, 2018
* Due to recent changes to the `example-data` file, the `ExampleData` class accidentally no longer adds the additional files to the `exampleFiles` property. This means that those files aren't copied over to StackBlitz.
* Cleans up the example data file.

Fixes angular#9541.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in sample file.
5 participants