Skip to content

RxJS lettable operators are now called pipeable operators #9511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2018
Merged

RxJS lettable operators are now called pipeable operators #9511

merged 1 commit into from
Jan 22, 2018

Conversation

SchnWalter
Copy link
Contributor

As of RxJS v6.0.0-alpha.2 "lettable" operators are called pipeable:

https://github.com/ReactiveX/rxjs/blob/6.0.0-alpha.2/doc/lettable-operators.md

@SchnWalter SchnWalter requested a review from jelbourn as a code owner January 21, 2018 17:13
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 21, 2018
amcdnl
amcdnl approved these changes Jan 21, 2018
View reviewed changes
Copy link
Contributor

@amcdnl amcdnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 22, 2018
jelbourn
jelbourn approved these changes Jan 22, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 5d77d90 into angular:master Jan 22, 2018
@SchnWalter SchnWalter deleted the rxjs-pipeable-operators branch January 23, 2018 00:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amcdnl amcdnl amcdnl approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SchnWalter @amcdnl @jelbourn @googlebot @josephperrott