Skip to content

docs(dialog): document how to set default options using MAT_DEFAULT_DIALOG_OPTIONS #9319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2018
Merged

docs(dialog): document how to set default options using MAT_DEFAULT_DIALOG_OPTIONS #9319

merged 3 commits into from
Jan 12, 2018

Conversation

CDDelta
Copy link

@CDDelta CDDelta commented Jan 10, 2018

Also fixes a small typo in mat-form-field docs.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 10, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 10, 2018
@@ -39,6 +39,16 @@ export class YourDialog {
}
```

Default dialog options can be specified by providing an instance of `MatDialogConfig` for MAT_DIALOG_DEFAULT_OPTIONS in your application's root module.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give this block a header:

### Specifying global configuration defaults

Also line-break at 100 columns.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit acd9066 into angular:master Jan 12, 2018
andrewseguin pushed a commit that referenced this pull request Jan 17, 2018
…IALOG_OPTIONS (#9319)

* docs(dialog): document how to set default options

* docs(form-field): fix typo

* Address comments
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants