docs: clean up example config and data generation #9223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
crisbeto
commented
Jan 3, 2018
crisbeto
commented
- Removes all of the optional properties being passed in as null in the example config. Also adds stronger typing to the list.
- Cleans up the example data generation to be closer to the rest of the project.
googlebot
added
the
cla: yes
jelbourn
reviewed
Jan 5, 2018
| selectorName?: string; | ||
| } | ||
|
|
||
| export const EXAMPLE_COMPONENTS: {[key: string]: LiveExample} = { |
There was a problem hiding this comment.
This file is generated- did you update the script that writes it?
There was a problem hiding this comment.
AFAIK that’s the example-data.ts. It already has all the null checks.
There was a problem hiding this comment.
gulp build-examples-module writes this file
There was a problem hiding this comment.
Oh I see, I must've missed the warning because of all the imports. I've updated the generation script now.
* Removes all of the optional properties being passed in as null in the example config. Also adds stronger typing to the list. * Cleans up the example data generation to be closer to the rest of the project.
crisbeto
force-pushed
the
docs-redundant-config
branch
from
a837627 to
27681a5
Compare
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Jan 17, 2018
* Removes all of the optional properties being passed in as null in the example config. Also adds stronger typing to the list. * Cleans up the example data generation to be closer to the rest of the project.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.