Skip to content

fix(tabs): maintain selected tab when new tabs are added or removed #9132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 46 additions & 2 deletions src/lib/tabs/tab-group.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -282,14 +282,17 @@ describe('MatTabGroup', () => {
expect(tabs[3].origin).toBeGreaterThanOrEqual(0);

// Add a new tab in the beginning and select it, expect an origin < than 0 (animate left)
fixture.componentInstance.tabs.push({label: 'New tab', content: 'to left of index'});
fixture.componentInstance.selectedIndex = 0;
fixture.detectChanges();
tick();

fixture.componentInstance.tabs.push({label: 'New tab', content: 'to left of index'});
fixture.detectChanges();
tick();

tabs = component._tabs.toArray();
expect(tabs[0].origin).toBeLessThan(0);
}));
}));


it('should update selected index if the last tab removed while selected', fakeAsync(() => {
Expand All @@ -309,6 +312,47 @@ describe('MatTabGroup', () => {
expect(component.selectedIndex).toBe(numberOfTabs - 2);
}));


it('should maintain the selected tab if a new tab is added', () => {
fixture.detectChanges();
const component: MatTabGroup =
fixture.debugElement.query(By.css('mat-tab-group')).componentInstance;

fixture.componentInstance.selectedIndex = 1;
fixture.detectChanges();

// Add a new tab at the beginning.
fixture.componentInstance.tabs.unshift({label: 'New tab', content: 'at the start'});
fixture.detectChanges();

expect(component.selectedIndex).toBe(2);
expect(component._tabs.toArray()[2].isActive).toBe(true);
});


it('should maintain the selected tab if a tab is removed', () => {
// Add a couple of tabs so we have more to work with.
fixture.componentInstance.tabs.push(
{label: 'New tab', content: 'with new content'},
{label: 'Another new tab', content: 'with newer content'}
);

// Select the second-to-last tab.
fixture.componentInstance.selectedIndex = 3;
fixture.detectChanges();

const component: MatTabGroup =
fixture.debugElement.query(By.css('mat-tab-group')).componentInstance;

// Remove a tab right before the selected one.
fixture.componentInstance.tabs.splice(2, 1);
fixture.detectChanges();

expect(component.selectedIndex).toBe(1);
expect(component._tabs.toArray()[1].isActive).toBe(true);
});


});

describe('async tabs', () => {
Expand Down
10 changes: 10 additions & 0 deletions src/lib/tabs/tab-group.ts
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,16 @@ export class MatTabGroup extends _MatTabGroupMixinBase implements AfterContentIn
// Subscribe to changes in the amount of tabs, in order to be
// able to re-render the content as new tabs are added or removed.
this._tabsSubscription = this._tabs.changes.subscribe(() => {
const tabs = this._tabs.toArray();

// Maintain the previously-selected tab if a new tab is added or removed.
for (let i = 0; i < tabs.length; i++) {
if (tabs[i].isActive) {
this._indexToSelect = i;
break;
}
}

this._subscribeToTabLabels();
this._changeDetectorRef.markForCheck();
});
Expand Down