refactor(datepicker): use common overlay keyboard handling #8941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
added
pr: lgtm
action: merge
josephperrott
added
pr: needs rebase
and removed
action: merge
|
@crisbeto please rebase |
crisbeto
force-pushed
the
datepicker-keyboard-dispatcher
branch
from
d265ada to
0fd1117
Compare
crisbeto
added
action: merge
|
Rebased. |
|
@crisbeto passes presubmit, just needs rebase |
Switches the datepicker to use the `OverlayKeyboardDispatcher`, rather than managing the keyboard logic itself. This simplifies things and handles the cases where the popup won't close if it lost focus.
crisbeto
force-pushed
the
datepicker-keyboard-dispatcher
branch
from
0fd1117 to
9ba9981
Compare
|
Rebased and fixed a test failure. |
jelbourn
added
target: minor
|
Changing to minor release since it doesn't cherry-pick cleanly |
tinayuangao
pushed a commit
that referenced
this pull request
Jan 10, 2018
Switches the datepicker to use the `OverlayKeyboardDispatcher`, rather than managing the keyboard logic itself. This simplifies things and handles the cases where the popup won't close if it lost focus.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the datepicker to use the
OverlayKeyboardDispatcher, rather than managing the keyboard events itself. This simplifies things and handles the cases where the popup won't close if it lost focus.