Skip to content

feat(autocomplete): allow option ripples to be disabled #8851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2018
Merged

feat(autocomplete): allow option ripples to be disabled #8851

merged 1 commit into from
Jan 4, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 6, 2017

For consistency with other components like MatSelect, these changes add the ability for all of the option ripples to be disabled by using the disableRipple attribute on MatAutocomplete.

@crisbeto crisbeto requested a review from kara as a code owner December 6, 2017 22:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 6, 2017
jelbourn
jelbourn approved these changes Dec 7, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed pr: needs review labels Dec 7, 2017
@andrewseguin
Copy link
Contributor

Needs rebase

@crisbeto crisbeto force-pushed the autocomplete-disable-ripple branch from e02e6e1 to 7e1560d Compare December 13, 2017 22:56
@crisbeto
feat(autocomplete): allow option ripples to be disabled
fdb2713 
For consistency with other components like `MatSelect`, these changes add the ability for all of the option ripples to be disabled by using the `disableRipple` attribute on `MatAutocomplete`.
@crisbeto crisbeto force-pushed the autocomplete-disable-ripple branch from 7e1560d to fdb2713 Compare December 22, 2017 20:44
@jelbourn jelbourn merged commit ff31ac8 into angular:master Jan 4, 2018
tinayuangao pushed a commit that referenced this pull request Jan 10, 2018
@crisbeto @tinayuangao
feat(autocomplete): allow option ripples to be disabled (#8851)
c2c46b5 
For consistency with other components like `MatSelect`, these changes add the ability for all of the option ripples to be disabled by using the `disableRipple` attribute on `MatAutocomplete`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@kara kara Awaiting requested review from kara

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @andrewseguin @jelbourn @googlebot