Skip to content

docs(chips): Property binding #8839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2017
Merged

docs(chips): Property binding #8839

merged 1 commit into from
Dec 6, 2017

Conversation

ni-kit
Copy link
Contributor

@ni-kit ni-kit commented Dec 6, 2017

Added property binding to chips example code to prevent runtime error.

@ni-kit
docs(chips): Property binding
e2263ad 
Added property binding to chips example code to prevent runtime error.
@ni-kit ni-kit requested a review from tinayuangao as a code owner December 6, 2017 13:24
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 6, 2017
josephperrott
josephperrott approved these changes Dec 6, 2017
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 6, 2017
@mmalerba mmalerba merged commit 03b7e84 into angular:master Dec 6, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ni-kit @josephperrott @googlebot @mmalerba