refactor(autocomplete): switch to fakeAsync tests #8781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switches (almost) all of the autocomplete tests to run in the `fakeAsync` zone. * Adds a `MockNgZone` provider that allows us to flush out the `NgZone.onStable` subscriptions in `fakeAsync` tests. * Fixes the "should close the panel when the user clicks away" test not doing anything due to being wrapped in a `whenStable` callback but not running in an async zone. * Avoids recompiling all of the test components inside a `beforeEach`. The above-mentioned changes cut down the autocomplete testing time from ~30sec to ~10sec.
googlebot
added
the
cla: yes
crisbeto
added
pr: merge safe
and removed
in progress
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fakeAsynczone.MockNgZoneprovider that allows us to flush out theNgZone.onStablesubscriptions infakeAsynctests.whenStablecallback but not running in an async zone.beforeEach.The above-mentioned changes cut down the autocomplete testing time from ~30sec to ~10sec.