fix(expansion-panel): expand animation jumping #8779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| [@bodyExpansion]="_getExpandedState()" | ||
| (@bodyExpansion.done)="_bodyAnimation($event)" | ||
| (@bodyExpansion.start)="_bodyAnimation($event)" | ||
| [id]="id" |
There was a problem hiding this comment.
Why are we binding the id here?
There was a problem hiding this comment.
It was there before my changes so I'm not sure. I think it's for a11y, because it allows us to reference it in something like aria-owns.
There was a problem hiding this comment.
I think you're right. I think it is for aria-owns
josephperrott
added
pr: lgtm
action: merge
crisbeto
added
target: minor
andrewseguin
added
the
presubmit failures
josephperrott
added
pr: needs rebase
and removed
action: merge
|
@crisbeto please rebase |
crisbeto
force-pushed
the
expansion-panel-animation-jump
branch
from
574b2d1 to
5005971
Compare
crisbeto
added
action: merge
|
Rebased. |
crisbeto
force-pushed
the
expansion-panel-animation-jump
branch
from
5005971 to
7d00678
Compare
Fixes the expansion panel jumping towards the end of the animation due to the overflow going from `visible` to `hidden`.
crisbeto
force-pushed
the
expansion-panel-animation-jump
branch
from
7d00678 to
c140638
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the expansion panel jumping towards the end of the animation due to the overflow going from
visibletohidden.Here's what it looks like now for reference:
