-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(focus-origin): focus origin sometimes invalid in firefox 57 #8669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(focus-origin): focus origin sometimes invalid in firefox 57 #8669
Conversation
9c6f8df
to
12b19d1
Compare
12b19d1
to
27b1bad
Compare
needs rebase |
27b1bad
to
88f5ea4
Compare
@devversion please rebase, re-apply |
88f5ea4
to
b75c7e5
Compare
@mmalerba Rebased. I didn't apply |
* Sometimes the focus origin is not valid because Firefox seems to focus a tick after the keyboard/interaction event fired a tick before. To ensure the focus origin is always correct, the focus origin will be added to the next tick event loop Fixes angular#6984
b75c7e5
to
d43c144
Compare
I think we should try, it may wind up causing too many failures in google3 to be feasible. I'll mark it merge ready so the caretaker can at least try though |
@devversion it looks like we did presubmit this a while back and it seemed fine, it has a failing test on travis though |
@mmalerba Should be fixed now. |
Sometimes the focus origin is not valid because Firefox seems to focus a tick after the keyboard/interaction event fired a tick before. To ensure the focus origin is always correct, the focus origin will be added to the next tick event loop Fixes #6984
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #6984