Skip to content

build: add material experimental package #8591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2017
Merged

build: add material experimental package #8591

merged 1 commit into from
Nov 29, 2017

Conversation

devversion
Copy link
Member

@devversion devversion commented Nov 22, 2017 •
edited
Loading

  • Adds the material-experimental package.
  • Speeds up the AOT task by no longer copying the release directories (follow-up for e2e app)
  • No longer rebuilds everything on changes (demo-app serving)

@jelbourn Everything passed in the CI, just the IE11 failure that Kristiyan mentioned is causing the red status.

@devversion devversion requested a review from jelbourn as a code owner November 22, 2017 14:27
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 22, 2017
@devversion devversion force-pushed the build/add-material-experimental-package branch from 671ee7c to 9398afa Compare November 22, 2017 14:32
@devversion
build: add material experimental package
a21d84a 
* Adds the material-experimental package.
@devversion devversion force-pushed the build/add-material-experimental-package branch from 9398afa to a21d84a Compare November 23, 2017 14:48
jelbourn
jelbourn approved these changes Nov 28, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 28, 2017
@tinayuangao tinayuangao merged commit 71305ce into angular:master Nov 29, 2017
@devversion devversion deleted the build/add-material-experimental-package branch November 29, 2017 21:51
tinayuangao pushed a commit to tinayuangao/material2 that referenced this pull request Nov 29, 2017
@devversion @tinayuangao
build: add material experimental package (angular#8591)
72d9e45 
* Adds the material-experimental package.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @tinayuangao