chore: remove tslint type workaround #8451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
requested review from
crisbeto,
jelbourn and
mmalerba
as code owners
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
devversion
force-pushed
the
chore/remove-tslint-workaround
branch
from
0704322 to
bdd9432
Compare
* Due to a TSLint issue (palantir/tslint#2470) imports that were used as a type argument were treated as unused. This has been fixed with TypeScript ^2.4.0 and the workaround (using `//tslint:disable` comments) can be removed.
devversion
force-pushed
the
chore/remove-tslint-workaround
branch
from
bdd9432 to
85aaf8d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//tslint:disablecomments) can be removed.@jelbourn Also sorted the imports in those files using the module-based sort thing from WS.