Skip to content

fix(slide-toggle): height collapsing if component doesn't have a label #8270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 7, 2017

Fixes the slide label component collapsing down to 16px if it doesn't have a label.

Fixes #8264.

@crisbeto crisbeto requested a review from devversion as a code owner November 7, 2017 08:15
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 7, 2017
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 7, 2017
@devversion devversion removed their assignment Nov 11, 2017
@crisbeto crisbeto force-pushed the 8264/slide-toggle-collapse branch from d2aafa2 to 77ef20d Compare November 19, 2017 08:49
Fixes the slide label component collapsing down to 16px if it doesn't have a label.

Fixes angular#8264.
@crisbeto crisbeto force-pushed the 8264/slide-toggle-collapse branch from 77ef20d to 33dd94b Compare November 20, 2017 20:29
@tinayuangao tinayuangao merged commit 8205cb2 into angular:master Nov 29, 2017
tinayuangao pushed a commit to tinayuangao/material2 that referenced this pull request Nov 29, 2017
angular#8270)

Fixes the slide label component collapsing down to 16px if it doesn't have a label.

Fixes angular#8264.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MatSlideToggle without label is default styled such that it does not center correctly
4 participants