Skip to content

docs(dialog): don't say that entryComponents is for AOT only #8133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2017
Merged

docs(dialog): don't say that entryComponents is for AOT only #8133

merged 1 commit into from
Oct 30, 2017

Conversation

jelbourn
Copy link
Member

Fixes #8102

@jelbourn jelbourn added docs This issue is related to documentation pr: merge safe labels Oct 30, 2017
@jelbourn jelbourn requested a review from crisbeto October 30, 2017 21:17
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 30, 2017
crisbeto
crisbeto approved these changes Oct 30, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 30, 2017
@mmalerba mmalerba merged commit 10c1c06 into angular:master Oct 30, 2017
@jelbourn jelbourn deleted the dialog-docs-aot branch April 2, 2018 22:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dialog Service Docs Need Updated: AOT & EntryComponent
4 participants
@jelbourn @crisbeto @googlebot @mmalerba