-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(dialog): dialogs that hit max-width not centered on IE #8055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fe8db1e
to
39fe290
Compare
Fixes dialogs that hit their `max-width` no longer being centered in IE11. This seems like a regression introduced after 57f19cd.
39fe290
to
41d1624
Compare
) Fixes dialogs that hit their `max-width` no longer being centered in IE11. This seems like a regression introduced after 57f19cd.
…ngular#8055)" This reverts commit 65b63bb.
Okay, bad news :( This PR ended up having an unexpected issue in a screenshot diff that I think needs to be resolved before we merge this back in. To reproduce this in the demo app, go to the Start the demo app and observe that the Now, revert your changes: on See now that the dimensions of This was a problem in one app where their content assumed that they could use |
Let's park this one until #9236 gets in, I think it has some changes that could help with the initial issue. |
Fixes dialogs that hit their `max-width` no longer being centered in IE11. This seems like a regression introduced after 57f19cd.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes dialogs that hit their
max-width
no longer being centered in IE11. This seems like a regression introduced after 57f19cd.