build: fix examples not building #7939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
reviewed
Oct 21, 2017
tools/gulp/packages.ts
Outdated
| export const examplesPackage = new BuildPackage('material-examples', [ | ||
| materialPackage, | ||
| cdkPackage, | ||
| momentAdapterPackage |
There was a problem hiding this comment.
If you only add momentAdapterPackage, then it won't build material or the cdk a second time. The dependencies of the momentAdapterPackage will be installed automatically (see other packages)
Fixes an error in the `material-examples` build, because the Moment adapter wasn't added as a dependency.
crisbeto
force-pushed
the
examples-missing-dependency
branch
from
f48e6dd to
7d8cf36
Compare
devversion
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error in the
material-examplesbuild, because the Moment adapter wasn't added as a dependency.