Skip to content

chore(spinner): avoid deprecation warning in Safari #7810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2017
Merged

chore(spinner): avoid deprecation warning in Safari #7810

merged 1 commit into from
Nov 3, 2017

Conversation

crisbeto
Copy link
Member

Fixes a deprecation warning that was being logged by the spinner on Safari.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 15, 2017
josephperrott
josephperrott approved these changes Oct 16, 2017
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 16, 2017
This was referenced Oct 26, 2017
Closed
Closed
@crisbeto
Copy link
Member Author

@jelbourn bumping this to a P2, because it seems to be breaking slightly older versions on Firefox. See #8064.

@crisbeto crisbeto added the P2 The issue is important to a large percentage of users, with a workaround label Oct 27, 2017
@mayankku
Copy link

mayankku commented Nov 2, 2017

Any ETA on this?

@crisbeto
chore(spinner): avoid deprecation warning in Safari
b1040cb 
Fixes a deprecation warning that was being logged by the spinner on Safari.
@crisbeto crisbeto force-pushed the spinner-deprecation-warning branch from 0a73f12 to b1040cb Compare November 2, 2017 17:40
@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful and removed P2 The issue is important to a large percentage of users, with a workaround labels Nov 3, 2017
@andrewseguin andrewseguin merged commit 24f0471 into angular:master Nov 3, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crisbeto @mayankku @josephperrott @jelbourn @googlebot @andrewseguin