Skip to content

build: run tests against ios10 #7707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2017
Merged

build: run tests against ios10 #7707

merged 1 commit into from
Oct 12, 2017

Conversation

devversion
Copy link
Member

No description provided.

@devversion devversion requested a review from jelbourn as a code owner October 11, 2017 12:35
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 11, 2017
@devversion devversion force-pushed the build/run-tests-io10 branch from 0d89c76 to 690e2b5 Compare October 11, 2017 12:40
@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 11, 2017
jelbourn
jelbourn approved these changes Oct 11, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion
Copy link
Member Author

devversion commented Oct 11, 2017 •
edited
Loading

@jelbourn FYI: There are a few flaky tests on the select right now. Also one tooltip test is failing on Mobile Safari (even with iOS 9 -> unrelated) - See: https://travis-ci.org/angular/material2/jobs/286285703#L1887

@andrewseguin andrewseguin merged commit 0ab6ebe into angular:master Oct 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @andrewseguin