Skip to content

chore: remove accessor type workaround #7659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Due to angular/dgeni-packages#246 the Material docs package used a workaround for accessor types.

The issue has been fixed with angular/dgeni-packages#247 and the workaround can be removed now.

@devversion devversion added docs This issue is related to documentation pr: merge safe labels Oct 9, 2017
@devversion devversion requested a review from jelbourn as a code owner October 9, 2017 15:35
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 9, 2017
Due to angular/dgeni-packages#246 the Material docs package used a workaround for accessor types.

The issue has been fixed with angular/dgeni-packages#247 and the workaround can be removed now.
@devversion devversion force-pushed the chore/remove-accessor-type-workaround branch from 94e82a3 to 1f33503 Compare October 9, 2017 16:07
@devversion devversion mentioned this pull request Oct 9, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 11, 2017
@andrewseguin andrewseguin merged commit b6f7f17 into angular:master Oct 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants