Skip to content

fix(stepper): switch to OnPush change detection #7119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2017
Merged

fix(stepper): switch to OnPush change detection #7119

merged 1 commit into from
Oct 4, 2017

Conversation

crisbeto
Copy link
Member

  • Adds OnPush change detection to all stepper-related components.
  • Enables the tslint rule that requires OnPush for all components.

@crisbeto crisbeto added the in progress This issue is currently in progress label Sep 16, 2017
@crisbeto crisbeto requested a review from jelbourn as a code owner September 16, 2017 09:15
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 16, 2017
@crisbeto crisbeto force-pushed the stepper-onpush branch 2 times, most recently from a736791 to 5dc1893 Compare September 16, 2017 10:45
@crisbeto crisbeto mentioned this pull request Sep 16, 2017
Closed
@crisbeto crisbeto added pr: needs review and removed in progress This issue is currently in progress labels Sep 16, 2017
jelbourn
jelbourn approved these changes Sep 16, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 16, 2017
@andrewseguin
Copy link
Contributor

Needs rebase

@andrewseguin andrewseguin added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Sep 29, 2017
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Sep 30, 2017
@kara kara added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Oct 3, 2017
@kara kara assigned crisbeto and unassigned jelbourn Oct 3, 2017
@kara
Copy link
Contributor

kara commented Oct 3, 2017

@crisbeto Rebase?

@crisbeto
fix(stepper): switch to OnPush change detection
9da5506 
* Adds OnPush change detection to all stepper-related components.
* Enables the tslint rule that requires OnPush for all components.
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Oct 3, 2017
@crisbeto
Copy link
Member Author

crisbeto commented Oct 3, 2017

Ready to go.

@kara kara merged commit c2c6e04 into angular:master Oct 4, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @andrewseguin @kara @jelbourn @googlebot