fix(datepicker): make sure _datepickerInput exists before accessing its #7033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Sep 13, 2017
| @@ -148,7 +148,8 @@ export class MdDatepicker<D> implements OnDestroy { | |||
| /** Whether the datepicker pop-up should be disabled. */ | |||
| @Input() | |||
| get disabled() { | |||
| return this._disabled === undefined ? this._datepickerInput.disabled : this._disabled; | |||
| return this._disabled === undefined && this._datepickerInput ? | |||
| this._datepickerInput.disabled : this._disabled; | |||
There was a problem hiding this comment.
Could you write a unit test that captures the situation in which this._datepickerInput would be undefined?
disabled property.
mmalerba
force-pushed
the
dp-disabled
branch
from
ce1472e to
4e384c1
Compare
mmalerba
force-pushed
the
dp-disabled
branch
from
4e384c1 to
d409aa3
Compare
|
test added, PTAL |
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disabled property.