demo(list): Add accessibility demo page for list #7020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinayuangao
requested review from
amcdnl,
crisbeto and
jelbourn
as code owners
googlebot
added
the
cla: yes
crisbeto
reviewed
Sep 12, 2017
src/lib/list/list.ts
Outdated
| @Directive({ | ||
| selector: 'md-nav-list, mat-nav-list', | ||
| host: {'class': 'mat-nav-list'} | ||
| template: '<ng-content></ng-content>', |
There was a problem hiding this comment.
I think that in general we still keep the templates in a separate HTML file, even if it's a one-liner.
| <h2> Seasoning </h2> | ||
| <p>Showing a non-interactive list of seasonings.</p> | ||
| <md-list role="list"> | ||
| <md-list-item *ngFor="let item of items"> {{item}} </md-list-item> |
There was a problem hiding this comment.
Shouldn't all of these list items have a role="listitem"?
There was a problem hiding this comment.
role="listitem" is added in list.ts so we don't need to add it here.
There was a problem hiding this comment.
Weren't we going to remove that from the list-item?
tinayuangao
added
action: merge
tinayuangao
force-pushed
the
list
branch
3 times, most recently
from
89e44b2 to
b2329cf
Compare
kara
added
pr: needs rebase
and removed
action: merge
|
@tinayuangao Rebase? |
tinayuangao
added a commit
to tinayuangao/material2
that referenced
this pull request
Nov 29, 2017
* demo(list): Add accessibility demo page for list * fix test * set default role for md-list * fix test * Add template file for list
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #6363 is accidentally changed to change of changelog.md