Skip to content

fix(overlay): rename OverlayState to OverlayConfig #6972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2017
Merged

fix(overlay): rename OverlayState to OverlayConfig #6972

merged 1 commit into from
Sep 20, 2017

Conversation

jelbourn
Copy link
Member

BREAKING CHANGE: OverlayState has been renamed to OverlayConfig

@jelbourn jelbourn requested review from kara and crisbeto September 10, 2017 19:06
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 10, 2017
crisbeto
crisbeto approved these changes Sep 10, 2017
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 10, 2017
@mmalerba mmalerba added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Sep 11, 2017
@mmalerba
Copy link
Contributor

please rebase

@jelbourn
Copy link
Member Author

@mmalerba rebased

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Sep 13, 2017
@jelbourn
fix(overlay): rename OverlayState to OverlayConfig
b2c71cf 
BREAKING CHANGE: OverlayState has been renamed to OverlayConfig
@jelbourn jelbourn added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Sep 15, 2017
@jelbourn jelbourn merged commit 1cfce8d into angular:master Sep 20, 2017
@gozeon gozeon mentioned this pull request Dec 11, 2017
Closed
@jelbourn jelbourn deleted the overlay-config branch April 2, 2018 22:30
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@kara kara Awaiting requested review from kara

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@josephperrott josephperrott Awaiting requested review from josephperrott

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jelbourn @mmalerba @crisbeto @googlebot