fix(form-field): placeholder not floating if autofilled #6839
Conversation
googlebot
added
the
cla: yes
| @@ -49,7 +49,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| .mat-form-field-autofill-float:-webkit-autofill + .mat-form-field-placeholder, | |||
There was a problem hiding this comment.
Can you instead just add the mat-form-field-autofill-float class to the MdInput? This was intended as a class users could add to custom a MdFormFieldControl to get the same effect, but I forgot to actually add it, haha...
There was a problem hiding this comment.
Wouldn't that involve injecting the parent MdFormField to see if the floating placeholder is enabled or not? (which might not be wrong; just asking)
There was a problem hiding this comment.
Addressed discussed feedback from Slack.
mmalerba
added
pr: lgtm
action: merge
If a form-field value is set through autofill, the floating placeholder should float and not overlay the form-field value. This doesn't work in Chrome because the `.mat-form-field-autofill-float` class doesn't exist and can't be set on the form-field control anyway. Fixes angular#6837
devversion
force-pushed
the
fix/form-field-autofill-float
branch
from
c4d9aa2 to
0e592b3
Compare
devversion
added
the
P1
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
If a form-field value is set through autofill, the floating placeholder should float and not overlay the form-field value. This doesn't work in Chrome because the
.mat-form-field-autofill-floatclass doesn't exist and can't be set on the form-field control anyway.Fixes #6837