Skip to content

fix: enforce multiline selectors use backtick #6386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2017
Merged

fix: enforce multiline selectors use backtick #6386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b002e00
fix: enforce multiline selectors use backtick
andrewseguin Aug 9, 2017
03785b1
add checkbox validator
andrewseguin Aug 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/autocomplete/autocomplete-trigger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ export function getMdAutocompleteMissingPanelError(): Error {
}

@Directive({
selector: 'input[mdAutocomplete], input[matAutocomplete],' +
'textarea[mdAutocomplete], textarea[matAutocomplete]',
selector: `input[mdAutocomplete], input[matAutocomplete],
textarea[mdAutocomplete], textarea[matAutocomplete]`,
host: {
'role': 'combobox',
'autocomplete': 'off',
Expand Down
8 changes: 4 additions & 4 deletions src/lib/button/button.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,10 @@ export const _MdButtonMixinBase = mixinColor(mixinDisabled(mixinDisableRipple(Md
*/
@Component({
moduleId: module.id,
selector: 'button[md-button], button[md-raised-button], button[md-icon-button],' +
'button[md-fab], button[md-mini-fab],' +
'button[mat-button], button[mat-raised-button], button[mat-icon-button],' +
'button[mat-fab], button[mat-mini-fab]',
selector: `button[md-button], button[md-raised-button], button[md-icon-button],
button[md-fab], button[md-mini-fab],
button[mat-button], button[mat-raised-button], button[mat-icon-button],
button[mat-fab], button[mat-mini-fab]`,
host: {
'[disabled]': 'disabled || null',
},
Expand Down
8 changes: 4 additions & 4 deletions src/lib/card/card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ export class MdCardContent {}
* @docs-private
*/
@Directive({
selector: 'md-card-title, mat-card-title, [md-card-title], [mat-card-title],' +
'[mdCardTitle], [matCardTitle]',
selector: `md-card-title, mat-card-title, [md-card-title], [mat-card-title],
[mdCardTitle], [matCardTitle]`,
host: {
'class': 'mat-card-title'
}
Expand All @@ -43,8 +43,8 @@ export class MdCardTitle {}
* @docs-private
*/
@Directive({
selector: 'md-card-subtitle, mat-card-subtitle, [md-card-subtitle], [mat-card-subtitle],' +
'[mdCardSubtitle], [matCardSubtitle]',
selector: `md-card-subtitle, mat-card-subtitle, [md-card-subtitle], [mat-card-subtitle],
[mdCardSubtitle], [matCardSubtitle]`,
host: {
'class': 'mat-card-subtitle'
}
Expand Down
9 changes: 4 additions & 5 deletions src/lib/checkbox/checkbox-required-validator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,10 @@ export const MD_CHECKBOX_REQUIRED_VALIDATOR: Provider = {
* work with `md-checkbox`.
*/
@Directive({
selector:
'md-checkbox[required][formControlName],' +
'mat-checkbox[required][formControlName],' +
'md-checkbox[required][formControl],md-checkbox[required][ngModel],' +
'mat-checkbox[required][formControl],mat-checkbox[required][ngModel]',
selector: `md-checkbox[required][formControlName],
mat-checkbox[required][formControlName],
md-checkbox[required][formControl], md-checkbox[required][ngModel],
mat-checkbox[required][formControl], mat-checkbox[required][ngModel]`,
providers: [MD_CHECKBOX_REQUIRED_VALIDATOR],
host: {'[attr.required]': 'required ? "" : null'}
})
Expand Down
12 changes: 6 additions & 6 deletions src/lib/dialog/dialog-content-directives.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ let dialogElementUid = 0;
* Button that will close the current dialog.
*/
@Directive({
selector: 'button[md-dialog-close], button[mat-dialog-close],' +
'button[mdDialogClose], button[matDialogClose]',
selector: `button[md-dialog-close], button[mat-dialog-close],
button[mdDialogClose], button[matDialogClose]`,
host: {
'(click)': 'dialogRef.close(dialogResult)',
'[attr.aria-label]': 'ariaLabel',
Expand Down Expand Up @@ -75,8 +75,8 @@ export class MdDialogTitle implements OnInit {
* Scrollable content container of a dialog.
*/
@Directive({
selector: '[md-dialog-content], md-dialog-content, [mat-dialog-content], mat-dialog-content,' +
'[mdDialogContent], [matDialogContent]',
selector: `[md-dialog-content], md-dialog-content, [mat-dialog-content], mat-dialog-content,
[mdDialogContent], [matDialogContent]`,
host: {'class': 'mat-dialog-content'}
})
export class MdDialogContent { }
Expand All @@ -87,8 +87,8 @@ export class MdDialogContent { }
* Stays fixed to the bottom when scrolling.
*/
@Directive({
selector: '[md-dialog-actions], md-dialog-actions, [mat-dialog-actions], mat-dialog-actions,' +
'[mdDialogActions], [matDialogActions]',
selector: `[md-dialog-actions], md-dialog-actions, [mat-dialog-actions], mat-dialog-actions,
[mdDialogActions], [matDialogActions]`,
host: {'class': 'mat-dialog-actions'}
})
export class MdDialogActions { }
4 changes: 2 additions & 2 deletions src/lib/input/autosize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ import {Platform} from '@angular/cdk/platform';
* Directive to automatically resize a textarea to fit its content.
*/
@Directive({
selector: 'textarea[md-autosize], textarea[mdTextareaAutosize],' +
'textarea[mat-autosize], textarea[matTextareaAutosize]',
selector: `textarea[md-autosize], textarea[mdTextareaAutosize],
textarea[mat-autosize], textarea[matTextareaAutosize]`,
exportAs: 'mdTextareaAutosize',
host: {
'(input)': 'resizeToFitContent()',
Expand Down