fix(reposition-scroll-strategy): use last calculated position to re-align the overlay #5471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lign the overlay Uses the element's last calculated position to re-align it, instead of recomputing the position completely. This prevents the overlay from jumping into the viewport when the user scrolls away.
googlebot
added
the
cla: yes
jelbourn
reviewed
Jul 5, 2017
There was a problem hiding this comment.
It seems kind of weird to make this change to the OverlayRef and the GlobalPositionStrategy for something that only happens for the connected position strategy. Is there some way we could isolate the behavior to just that class, perhaps by providing it additional information?
|
Initially I did it with |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 15, 2017
… connected overlay Currently when updating the position of an open connected overlay (e.g. when the user is scrolling) we go through the same process for determining the preferred position as when the overlay was attached. This means that the preferred position could change, causing the overlay to jump. With these changes the overlay will determine its preferred position when it's attached and the re-use the same position until it's detached. This is a prerequisite to moving the scroll clipping logic out of the `ConnectedPositionStrategy` and into the scroll strategies. This PR is a resubmit of angular#5471.
|
Closing in favor of #7805. |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 29, 2017
…pplying to open connected overlay Currently when updating the position of an open connected overlay (e.g. when the user is scrolling) we go through the same process for determining the preferred position as when the overlay was attached. This means that the preferred position could change, causing the overlay to jump. With these changes the consumer can decide to lock an overlay into its initial position, preventing it from jumping. This PR is a resubmit of angular#5471.
jelbourn
pushed a commit
that referenced
this pull request
Nov 19, 2017
…pplying to open connected overlay Currently when updating the position of an open connected overlay (e.g. when the user is scrolling) we go through the same process for determining the preferred position as when the overlay was attached. This means that the preferred position could change, causing the overlay to jump. With these changes the consumer can decide to lock an overlay into its initial position, preventing it from jumping. This PR is a resubmit of #5471.
jelbourn
pushed a commit
that referenced
this pull request
Nov 20, 2017
…pplying to open connected overlay (#7805) Currently when updating the position of an open connected overlay (e.g. when the user is scrolling) we go through the same process for determining the preferred position as when the overlay was attached. This means that the preferred position could change, causing the overlay to jump. With these changes the consumer can decide to lock an overlay into its initial position, preventing it from jumping. This PR is a resubmit of #5471.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the element's last calculated position to re-align it, instead of recomputing the position completely. This prevents the overlay from jumping into the viewport when the user scrolls away.