Skip to content

style(button-toggle, slider, expansion): remove base colors in themes #5147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2017
Merged

style(button-toggle, slider, expansion): remove base colors in themes #5147

merged 3 commits into from
Jul 28, 2017

Conversation

willshowell
Copy link
Contributor

Removes use of base color in theme mixins

Checked button toggle

  • Light theme: black -> black 54%
  • Dark theme: white -> white 70%

Slider min thumb

  • Light theme: black -> black 87%

Expansion panel

  • Light theme: black -> black 87%

@willshowell
Cleanup harsh colors for selected button toggle
d2bb70e 
- Light theme: black -> black-54
- Dark theme: white -> white-70
@willshowell
Make the slider min thumb less harsh in light theme
3474aa2 
- Light theme: black -> black-87
- Dark theme: white -> white
@willshowell
Use default text color for expansion panel
89c30c4
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 15, 2017
@jelbourn jelbourn requested a review from tinayuangao July 11, 2017 22:17
@tinayuangao
Copy link
Contributor

LGTM

tinayuangao
tinayuangao approved these changes Jul 21, 2017
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinayuangao tinayuangao added the action: merge The PR is ready for merge by the caretaker label Jul 26, 2017
@andrewseguin andrewseguin merged commit 0409707 into angular:master Jul 28, 2017
@willshowell willshowell deleted the style/toggle-button branch July 28, 2017 14:48
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tinayuangao tinayuangao tinayuangao approved these changes

Assignees

@tinayuangao tinayuangao

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@willshowell @tinayuangao @jelbourn @googlebot @andrewseguin