build: fix multi-line selectors in dgeni #4336

devversion · 2017-04-30T18:08:43Z

Fixes multi-line selectors not being detected properly (https://github.com/angular/material2/blob/master/src/lib/button/button.ts#L185-L185)
Template strings not being detected properly (https://github.com/angular/material2/blob/master/src/lib/input/input-container.ts#L103-L103)
No longer repeats RegExp logic multiple times. More generic function.

Note: This is still a very naive approach, but it nearly works for every selector now. It only fails for selectors like: https://github.com/angular/material2/blob/master/src/lib/button/button.ts#L93-L93

* Fixes multi-line selectors not being detected properly (https://github.com/angular/material2/blob/master/src/lib/button/button.ts#L185-L185) * Template strings not being detected properly (https://github.com/angular/material2/blob/master/src/lib/input/input-container.ts#L103-L103) * No longer repeats RegExp logic multiple times. More generic function.

jelbourn

LGTM

angular-automatic-lock-bot · 2019-09-07T15:01:47Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

_{This action has been performed automatically by a bot.}

devversion added the pr: needs review label Apr 30, 2017

devversion assigned jelbourn Apr 30, 2017

devversion requested a review from jelbourn April 30, 2017 18:08

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 30, 2017

jelbourn approved these changes May 1, 2017

View reviewed changes

jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 1, 2017

andrewseguin merged commit 3acf2a2 into angular:master May 2, 2017

devversion deleted the build/dgeni-selector-meta branch November 11, 2017 10:20

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019

Provide feedback