Skip to content

style(checkbox,chips,tabs): remove hardcoded hues #4101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 2, 2017

Conversation

willshowell
Copy link
Contributor

Fixes #3813

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 14, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

jelbourn commented May 1, 2017

@willshowell just needs rebase

@willshowell willshowell force-pushed the fix-component-hues branch from a52f4bf to 480368a Compare May 1, 2017 22:24
@willshowell
Copy link
Contributor Author

@jelbourn done

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels May 1, 2017
@andrewseguin andrewseguin merged commit 4021276 into angular:master May 2, 2017
@willshowell
Copy link
Contributor Author

@jelbourn I just came across the specs for checkboxes and I see that the hues are actually defined to be 500. Should that portion of this PR be reverted or should that be interpreted as to mean the "default hue"?

Light

On: Swatch 500, Opacity 100%
Off: #000000, Opacity 54%
Disabled: #000000, Opacity 26%

Dark

On: Swatch 500, Opacity 100%
Off: #FFFFFF, Opacity 70%
Disabled: #FFFFFF, Opacity 30%

@jelbourn
Copy link
Member

I'm interpreting it as intending the default hue.

@willshowell willshowell deleted the fix-component-hues branch May 24, 2017 15:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent coloring for some components when not using 500 colors
4 participants