refactor: remove safe-color-change mixin #31219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
requested review from
adolgachev and
wagnermaciel
and removed request for
a team
andrewseguin
force-pushed
the
safe-color
branch
3 times, most recently
from
6a89ef7 to
e8c886a
Compare
andrewseguin
added
the
target: minor
crisbeto
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converge on using
get-theme-colorto get theme colors with opacity. The missing piece was thatget-theme colorwasn't variable-friendly, so now it returns a color-mix if the color is not a "color"Also, when possible, just use the foreground base color instead of various different colors when passing any opacity