Skip to content

refactor: remove component m3 tokens from theme config #31111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2025

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented May 14, 2025

Follow-up to #31099 where all component M3 token files now use the theme config to return a set of tokens to the theme file, rather than inserting into the theme config for later lookup

This streamlines the flow of defining theme configs and using them in the theme files

In general this change, for each component...

  • In the component styles, directly provides the system fallbacks that should be used for slots
  • In theme file, directly call the m3 token file to gather tokens
  • In the m3 tokens file, accept a theme config and use its values to determine the token values

@andrewseguin andrewseguin requested a review from a team as a code owner May 14, 2025 02:56
@andrewseguin andrewseguin requested review from adolgachev, ok7sai, crisbeto, mmalerba and wagnermaciel and removed request for a team, adolgachev and ok7sai May 14, 2025 02:56
@andrewseguin andrewseguin added target: rc This PR is targeted for the next release-candidate action: merge The PR is ready for merge by the caretaker labels May 15, 2025
@andrewseguin andrewseguin added target: patch This PR is targeted for the next patch release target: rc This PR is targeted for the next release-candidate target: minor This PR is targeted for the next minor release and removed target: rc This PR is targeted for the next release-candidate target: patch This PR is targeted for the next patch release labels May 15, 2025
@andrewseguin andrewseguin merged commit 5db4fcf into angular:main May 15, 2025
29 of 31 checks passed
andrewseguin added a commit to andrewseguin/components that referenced this pull request May 15, 2025
* refactor: remove component m3 tokens from theme config

* refactor: fixes found during internal testing

* refactor: more fixes

---------

Co-authored-by: Andrew Seguin <andrewseguin@google.com>
andrewseguin added a commit that referenced this pull request May 15, 2025
* refactor: remove component m3 tokens from theme config

* refactor: fixes found during internal testing

* refactor: more fixes

---------

Co-authored-by: Andrew Seguin <andrewseguin@google.com>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants