feat(material/chips): add (optional) edit icon to input chips #31041
+275
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
detected: feature
adolgachev
changed the title
adolgachev
added
Accessibility
|
Deployed dev-app for fe5ea55 to: https://ng-dev-previews-comp--pr-angular-components-31041-dev-jgj91wpx.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
adolgachev
force-pushed
the
chip-edit-icon
branch
2 times, most recently
from
c0b7505 to
0dfcea0
Compare
adolgachev
added
action: review
adolgachev
force-pushed
the
chip-edit-icon
branch
2 times, most recently
from
4960510 to
809e1e8
Compare
adolgachev
removed
the
action: global presubmit
crisbeto
reviewed
May 19, 2025
adolgachev
force-pushed
the
chip-edit-icon
branch
from
b5951a7 to
3dbe36d
Compare
crisbeto
reviewed
May 20, 2025
adolgachev
force-pushed
the
chip-edit-icon
branch
from
faec358 to
5c09c2b
Compare
adolgachev
added
the
docs: preview
|
Deployed docs-preview for fe5ea55 to: https://ng-dev-previews-comp--pr-angular-components-31041-docs-h4ff3yly.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
adolgachev
force-pushed
the
chip-edit-icon
branch
4 times, most recently
from
651cfd6 to
696752b
Compare
crisbeto
approved these changes
May 29, 2025
adolgachev
added
the
target: minor
adolgachev
force-pushed
the
chip-edit-icon
branch
2 times, most recently
from
ea342eb to
c779d8e
Compare
adolgachev
force-pushed
the
chip-edit-icon
branch
from
c8bbe6e to
fe5ea55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an optional edit icon to input chips to allow for better discoverability of editable chips over existing double-click and focus-enter to edit behavior.
The edit icon introduces concept of a leading action with an icon button similar to trailing action used for delete icon button. This can be combined with the existing avatar icon for a chip. The editable flag is preserved but is independent of the edit icon, allowing for both existing and new behavior or either one.
Updated chip demo to add option to show avatar and/or edit icon.