fix(material/chips): provide ability to edit for all screen readers with a click on already focused chip #30983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adolgachev
added
the
dev-app preview
|
Deployed dev-app for 291d8fe to: https://ng-dev-previews-comp--pr-angular-components-30983-dev-9kax7hje.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
adolgachev
changed the title
adolgachev
changed the title
adolgachev
added
the
requires: TGP
adolgachev
requested review from
mmalerba,
andrewseguin and
crisbeto
and removed request for
a team
adolgachev
added
the
action: review
crisbeto
reviewed
May 7, 2025
crisbeto
approved these changes
May 8, 2025
adolgachev
added
action: global presubmit
…ith a click on already focused chip
adolgachev
added
action: merge
adolgachev
added
target: minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some screen readers have difficulty with allowing users to say double click or enter with voice control, preventing them from being able to edit a chip which currently requires a double click or an enter key event.
Single click conflicts with other behaviors, but allowing a click when the chips has already been focused is a natural way to edit the chip and does not affect other current behaviors.
Fixes b/290806246.