Skip to content

[Cherry pick] fix(multiple): ensure mat-option parents are the offsetParent #30980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

crisbeto
Copy link
Member

Note: this is a cherry-pick of #30977.

We have several components where we use the offsetTop of the mat-option to determine how much to scroll, however this only works if the panel is the option's offsetParent. For that to happen we need a position different from static.

Fixes #30974.

…r#30977)

We have several components where we use the `offsetTop` of the `mat-option` to determine how much to scroll, however this only works if the panel is the option's `offsetParent`. For that to happen we need a position different from `static`.

Fixes angular#30974.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Apr 29, 2025
@crisbeto crisbeto requested a review from a team as a code owner April 29, 2025 17:54
@crisbeto crisbeto requested review from mmalerba and wagnermaciel and removed request for a team April 29, 2025 17:54
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 29, 2025
@crisbeto crisbeto merged commit 33a7217 into angular:19.2.x Apr 29, 2025
25 of 27 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants