Skip to content

fix(cdk/table): move out unused style scheduler #30963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions goldens/cdk/table/index.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,6 @@ export class CdkTable<T> implements AfterContentInit, AfterContentChecked, Colle
addRowDef(rowDef: CdkRowDef<T>): void;
// (undocumented)
protected readonly _changeDetectorRef: ChangeDetectorRef;
// (undocumented)
protected readonly _coalescedStyleScheduler: _CoalescedStyleScheduler;
readonly contentChanged: EventEmitter<void>;
_contentColumnDefs: QueryList<CdkColumnDef>;
_contentFooterRowDefs: QueryList<CdkFooterRowDef>;
Expand Down Expand Up @@ -414,20 +412,6 @@ export interface CellDef {
template: TemplateRef<any>;
}

// @public
export const _COALESCED_STYLE_SCHEDULER: InjectionToken<_CoalescedStyleScheduler>;

// @public
export class _CoalescedStyleScheduler {
constructor(...args: unknown[]);
schedule(task: () => unknown): void;
scheduleEnd(task: () => unknown): void;
// (undocumented)
static ɵfac: i0.ɵɵFactoryDeclaration<_CoalescedStyleScheduler, never>;
// (undocumented)
static ɵprov: i0.ɵɵInjectableDeclaration<_CoalescedStyleScheduler>;
}

// @public
export class DataRowOutlet implements RowOutlet {
constructor(...args: unknown[]);
Expand Down Expand Up @@ -506,14 +490,6 @@ export interface RowOutlet {
viewContainer: ViewContainerRef;
}

// @public
export class _Schedule {
// (undocumented)
endTasks: (() => unknown)[];
// (undocumented)
tasks: (() => unknown)[];
}

// @public
export const STICKY_POSITIONING_LISTENER: InjectionToken<StickyPositioningListener>;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,13 @@ import {
TABLE_LAYOUT_FIXED_RESIZE_STRATEGY_PROVIDER,
FLEX_RESIZE_STRATEGY_PROVIDER,
} from '../resize-strategy';
import {_COALESCED_STYLE_SCHEDULER, _CoalescedStyleScheduler} from '../coalesced-style-scheduler';

const PROVIDERS: Provider[] = [
ColumnResizeNotifier,
HeaderRowEventDispatcher,
ColumnResizeNotifierSource,
{provide: _COALESCED_STYLE_SCHEDULER, useClass: _CoalescedStyleScheduler},
];

export const TABLE_PROVIDERS: Provider[] = [
Expand Down
3 changes: 2 additions & 1 deletion src/cdk-experimental/column-resize/overlay-handle.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
import {coerceCssPixelValue} from '@angular/cdk/coercion';
import {Directionality} from '@angular/cdk/bidi';
import {ESCAPE} from '@angular/cdk/keycodes';
import {CdkColumnDef, _CoalescedStyleScheduler} from '@angular/cdk/table';
import {CdkColumnDef} from '@angular/cdk/table';
import {Subject, merge, Observable} from 'rxjs';
import {
distinctUntilChanged,
Expand All @@ -36,6 +36,7 @@ import {HEADER_CELL_SELECTOR} from './selectors';
import {ColumnResizeNotifierSource} from './column-resize-notifier';
import {HeaderRowEventDispatcher} from './event-dispatcher';
import {ResizeRef} from './resize-ref';
import {_CoalescedStyleScheduler} from './coalesced-style-scheduler';

// TODO: Take another look at using cdk drag drop. IIRC I ran into a couple
// good reasons for not using it but I don't remember what they were at this point.
Expand Down
1 change: 1 addition & 0 deletions src/cdk-experimental/column-resize/public-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ export * from './resizable';
export * from './resize-ref';
export * from './resize-strategy';
export * from './overlay-handle';
export * from './coalesced-style-scheduler';
3 changes: 2 additions & 1 deletion src/cdk-experimental/column-resize/resizable.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import {
createRepositionScrollStrategy,
OverlayRef,
} from '@angular/cdk/overlay';
import {CdkColumnDef, _CoalescedStyleScheduler} from '@angular/cdk/table';
import {CdkColumnDef} from '@angular/cdk/table';
import {merge, Subject} from 'rxjs';
import {distinctUntilChanged, filter, take, takeUntil} from 'rxjs/operators';

Expand All @@ -43,6 +43,7 @@ import {ColumnSizeStore} from './column-size-store';
import {HeaderRowEventDispatcher} from './event-dispatcher';
import {ResizeRef} from './resize-ref';
import {ResizeStrategy} from './resize-strategy';
import {_CoalescedStyleScheduler} from './coalesced-style-scheduler';

const OVERLAY_ACTIVE_CLASS = 'cdk-resizable-overlay-thumb-active';

Expand Down
3 changes: 2 additions & 1 deletion src/cdk-experimental/column-resize/resize-strategy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,10 @@
import {Injectable, OnDestroy, Provider, CSP_NONCE, inject, DOCUMENT} from '@angular/core';

import {coerceCssPixelValue} from '@angular/cdk/coercion';
import {CdkTable, _CoalescedStyleScheduler, _COALESCED_STYLE_SCHEDULER} from '@angular/cdk/table';
import {CdkTable} from '@angular/cdk/table';

import {ColumnResize} from './column-resize';
import {_COALESCED_STYLE_SCHEDULER, _CoalescedStyleScheduler} from './coalesced-style-scheduler';

/**
* Provides an implementation for resizing a column.
Expand Down
1 change: 0 additions & 1 deletion src/cdk/table/public-api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

export * from './table';
export * from './cell';
export * from './coalesced-style-scheduler';
export * from './row';
export * from './table-module';
export * from './sticky-position-listener';
Expand Down
Loading
Loading