fix(google-maps): implicitly include google.maps types instead of the triple slash workaround #30942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… triple slash workaround Previously, due to an issue with the rules_nodejs toolchain we had to include the google.maps namespace types via a triple slash comment with preserve set to true, this changes to instead include the types in the tsconfig as normal
josephperrott
added
action: merge
angular-robot
bot
removed
the
area: build & ci
josephperrott
requested review from
mmalerba and
andrewseguin
and removed request for
a team
andrewseguin
approved these changes
Apr 23, 2025
|
The changes were merged into the following branches: main, 19.2.x |
mmalerba
pushed a commit
that referenced
this pull request
Apr 24, 2025
… triple slash workaround (#30942) Previously, due to an issue with the rules_nodejs toolchain we had to include the google.maps namespace types via a triple slash comment with preserve set to true, this changes to instead include the types in the tsconfig as normal (cherry picked from commit cc61697)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, due to an issue with the
rules_nodejstoolchain we had to include thegoogle.mapsnamespace types via a triple slash comment with preserve set to true, this changes to instead include the types in the tsconfig as normal