Skip to content

fix(cdk/schematics): account for new karma builder #30907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

crisbeto
Copy link
Member

angular/angular-cli#29640 introduced a new Karma builder that appears to be the default in v20. These changes update our code so that the new builder is recognized.

I also move the names of the builders out into a constant so they're easier to update.

angular/angular-cli#29640 introduced a new Karma builder that appears to be the default in v20. These changes update our code so that the new builder is recognized.

I also move the names of the builders out into a constant so they're easier to update.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Apr 20, 2025
@crisbeto crisbeto requested a review from a team as a code owner April 20, 2025 07:43
@crisbeto crisbeto requested review from adolgachev and andrewseguin and removed request for a team April 20, 2025 07:43
@angular-robot angular-robot bot added the area: cdk/schematics cdk/schematics is *not* a public API label Apr 20, 2025
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 21, 2025
@crisbeto crisbeto merged commit 22876a9 into angular:main Apr 21, 2025
25 of 27 checks passed
@crisbeto
Copy link
Member Author

The changes were merged into the following branches: main, 19.2.x

crisbeto added a commit that referenced this pull request Apr 21, 2025
angular/angular-cli#29640 introduced a new Karma builder that appears to be the default in v20. These changes update our code so that the new builder is recognized.

I also move the names of the builders out into a constant so they're easier to update.

(cherry picked from commit 22876a9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/schematics cdk/schematics is *not* a public API target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants