Skip to content

refactor: merge component token files #30822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 8, 2025

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Apr 7, 2025

Reduces the number of token files so that each component has just one m2 and one m3 token file

BREAKING CHANGE:

  • Removes support for "ambiguous tokens" in the overrides API. For example, changing a button's container shape requires specifying the actual token, filled-container-shape instead of container-shape which previously affected all button variants.

@andrewseguin andrewseguin requested a review from a team as a code owner April 7, 2025 21:04
@andrewseguin andrewseguin requested review from crisbeto and wagnermaciel and removed request for a team April 7, 2025 21:04
@andrewseguin andrewseguin added the target: major This PR is targeted for the next major release label Apr 8, 2025
@andrewseguin andrewseguin changed the title Merge tokens refactor: merge component token files Apr 8, 2025
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Apr 8, 2025
@andrewseguin andrewseguin merged commit a7ff33c into angular:main Apr 8, 2025
20 of 22 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants