Skip to content

fix(material/form-field): use ResizeObserver for label offset calculation #30702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

mmalerba
Copy link
Contributor

No description provided.

@mmalerba mmalerba force-pushed the ff-ar branch 2 times, most recently from 2f113b6 to d8de830 Compare March 24, 2025 22:55
@mmalerba mmalerba changed the title WIP: attempt to use ResizeObserver for layout offset calculation WIP: attempt to use ResizeObserver for label offset calculation Mar 24, 2025
@mmalerba mmalerba force-pushed the ff-ar branch 5 times, most recently from 95a687b to 0124b29 Compare March 25, 2025 03:27
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: cdk/bidi labels Mar 25, 2025
@mmalerba mmalerba force-pushed the ff-ar branch 2 times, most recently from d535d15 to a198bee Compare March 25, 2025 17:37
@mmalerba mmalerba changed the title WIP: attempt to use ResizeObserver for label offset calculation fix(material/form-field): use ResizeObserver for label offset calculation Mar 25, 2025
@mmalerba mmalerba marked this pull request as ready for review March 25, 2025 17:40
@mmalerba mmalerba requested a review from a team as a code owner March 25, 2025 17:40
@mmalerba mmalerba requested review from crisbeto and wagnermaciel and removed request for a team March 25, 2025 17:40
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Mar 26, 2025
@mmalerba mmalerba merged commit ec538b5 into angular:main Mar 27, 2025
25 checks passed
mistrykaran91 pushed a commit to mistrykaran91/components that referenced this pull request Apr 7, 2025
…tion (angular#30702)

* feat(cdk/bidi): add value signal to Directionality

* fix(material/form-field): use ResizeObserver for label offset calculation
mmalerba added a commit to mmalerba/components that referenced this pull request Apr 17, 2025
angular#30702 added a `valueSignal`
property to `Directionality`, this PR adds it to the directionality
provided by cdk-dialog as well.
mmalerba added a commit to mmalerba/components that referenced this pull request Apr 17, 2025
angular#30702 added a `valueSignal`
property to `Directionality`, this PR adds it to the directionality
provided by cdk-dialog as well.
mmalerba added a commit that referenced this pull request Apr 18, 2025
#30702 added a `valueSignal`
property to `Directionality`, this PR adds it to the directionality
provided by cdk-dialog as well.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/bidi area: material/form-field detected: feature PR contains a feature commit target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants