docs(cdk/tree): examples not working when forked to Stackblitz #30601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
mmalerba and
andrewseguin
and removed request for
a team
The tree examples were breaking down when forked to Stackblitz, because of a couple of reasons: 1. They had their sample data in a separate file which the build process wasn't picking up. 2. They had compilation errors only with rxjs 7+ which we didn't notice, because our local setup is on rxjs 6. I also went through all the examples and moved the sample data further down so it doesn't distract from the actual code. Fixes angular#30600.
crisbeto
force-pushed
the
30600/tree-examples
branch
from
7817d36 to
23bc6bd
Compare
mmalerba
approved these changes
Mar 7, 2025
|
The changes were merged into the following branches: main, 19.2.x |
crisbeto
added a commit
that referenced
this pull request
Mar 7, 2025
The tree examples were breaking down when forked to Stackblitz, because of a couple of reasons: 1. They had their sample data in a separate file which the build process wasn't picking up. 2. They had compilation errors only with rxjs 7+ which we didn't notice, because our local setup is on rxjs 6. I also went through all the examples and moved the sample data further down so it doesn't distract from the actual code. Fixes #30600. (cherry picked from commit 5a98cc6)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tree examples were breaking down when forked to Stackblitz, because of a couple of reasons:
I also went through all the examples and moved the sample data further down so it doesn't distract from the actual code.
Fixes #30600.