-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/stepper): updates vertical-stepper aria roles #30577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
essjay05
wants to merge
23
commits into
angular:main
Choose a base branch
from
essjay05:change-vertical-stepper-aria-roles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
1c19858
fix(material/stepper): updates vertical-stepper aria roles
essjay05 bc6cf8f
refactor(material/stepper): remove shared mat-step-header
essjay05 98dc01c
fix(material/stepper): update vertical-stepper aria attributes
essjay05 184ba4e
test(material/stepper): updates role value for stepper.spec.ts
essjay05 293b553
test(material/stepper): update stepper tests
essjay05 acb42b6
test(material/stepper): fixes failing stepper tests
essjay05 7378a5b
test(material/stepper): revert updated harness files
essjay05 836efa6
refactor(material/stepper): remove aria-pressed from vertical stepper
essjay05 259f836
test(material/stepper): update stepper-harness tests
essjay05 ceeb984
build(material/stepper): update stepper api golden tests
essjay05 f1a804e
refactor(material/stepper): update code to use ng-container
essjay05 437a643
refactor(material/stepper): updates stepper to use same aria-roles pa…
essjay05 733dd27
docs(material/stepper): updates docs to use new aria roles
essjay05 c271b74
test(material/stepper): updates tests affected by new stepper aria ro…
essjay05 6ddd917
build(material/stepper): update stepper api goldens
essjay05 f00abdb
refactor(material/stepper): update aria-attributes for horizontal ste…
essjay05 d0bfa98
test(material/stepper): update tests based on new stepper aria-attrib…
essjay05 ffbc377
build(material/stepper): update api goldens
essjay05 95697f5
test(material/stepper): reset tests to use isSelected
essjay05 b5ce47b
fix(material/stepper): add default role to material/stepper/step-head…
essjay05 6423eb7
fix(material/stepper): add data-test-index attribute to improve unit …
essjay05 4118a0f
refactor(material/stepper): update naming convention for new index
essjay05 9974346
build(material/stepper): update material api goldens
essjay05 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.