fix(material/bottom-sheet): focus first tabbable element by default #30549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches the bottom sheet to focusing the first tabbale element by default like we do in `MatDialog`. Note that we had a comment saying that the previous behavior was intentional. That seems to be a leftover from angular#14534 where the underlying cause was that we were delaying focus until the animation is done. We now have better ways of handling it so the comment isn't relevant anymore. Fixes angular#30483.
crisbeto
requested review from
andrewseguin and
wagnermaciel
and removed request for
a team
crisbeto
commented
Feb 26, 2025
| bottomSheet.open(PizzaMsg, { | ||
| viewContainerRef: testViewContainerRef, | ||
| }); | ||
| it('should focus the bottom sheet element on open when autoFocus is set to "dialog"', fakeAsync(() => { |
There was a problem hiding this comment.
The changes below are mostly formatting.
andrewseguin
approved these changes
Feb 26, 2025
|
The changes were merged into the following branches: main, 19.2.x |
crisbeto
added a commit
that referenced
this pull request
Feb 26, 2025
…30549) Switches the bottom sheet to focusing the first tabbale element by default like we do in `MatDialog`. Note that we had a comment saying that the previous behavior was intentional. That seems to be a leftover from #14534 where the underlying cause was that we were delaying focus until the animation is done. We now have better ways of handling it so the comment isn't relevant anymore. Fixes #30483. (cherry picked from commit ee5b13f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the bottom sheet to focusing the first tabbale element by default like we do in
MatDialog.Note that we had a comment saying that the previous behavior was intentional. That seems to be a leftover from #14534 where the underlying cause was that we were delaying focus until the animation is done. We now have better ways of handling it so the comment isn't relevant anymore.
Fixes #30483.